fix(tokens): support style-dictionary build in windows env #2500
+4,514
−2,197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
castastrophe
added
the
skip_vrt
File metricsSummaryTotal size: 3.27 MB* Table reports on changes to a package's main file. Other changes can be found in the collapsed Details section below.
Detailstokens
* Results are not gzipped or minified. * An ASCII character in UTF-8 is 8 bits or 1 byte. |
|
🚀 Deployed on https://pr-2500--spectrum-css.netlify.app |
castastrophe
force-pushed
the
fix-tokens-windows-build
branch
from
676fef5 to
2c41fa6
Compare
castastrophe
force-pushed
the
fix-tokens-windows-build
branch
7 times, most recently
from
9548f0f to
deeeac9
Compare
castastrophe
added
the
low priority
castastrophe
force-pushed
the
fix-tokens-windows-build
branch
2 times, most recently
from
16f409e to
c0f9463
Compare
|
castastrophe
force-pushed
the
fix-tokens-windows-build
branch
3 times, most recently
from
098738b to
dc002cf
Compare
castastrophe
force-pushed
the
fix-tokens-windows-build
branch
from
dc002cf to
ae16d2a
Compare
castastrophe
force-pushed
the
fix-tokens-windows-build
branch
from
ae16d2a to
6cd570b
Compare
castastrophe
force-pushed
the
fix-tokens-windows-build
branch
2 times, most recently
from
dd0694c to
b565823
Compare
castastrophe
force-pushed
the
fix-tokens-windows-build
branch
from
b565823 to
20705b6
Compare
castastrophe
force-pushed
the
fix-tokens-windows-build
branch
from
20705b6 to
9164f9f
Compare
castastrophe
force-pushed
the
fix-tokens-windows-build
branch
from
9164f9f to
9880b3a
Compare
castastrophe
added
the
icebox
castastrophe
force-pushed
the
fix-tokens-windows-build
branch
from
cbbffd8 to
e1a3792
Compare
|
Something to evaluate: https://github.com/storybookjs/storybook/pull/29676/files |
castastrophe
force-pushed
the
fix-tokens-windows-build
branch
13 times, most recently
from
0fc864b to
38921ac
Compare
castastrophe
force-pushed
the
fix-tokens-windows-build
branch
4 times, most recently
from
a2fe0a5 to
e47aa37
Compare
castastrophe
force-pushed
the
fix-tokens-windows-build
branch
from
e47aa37 to
85f0636
Compare
castastrophe
force-pushed
the
fix-tokens-windows-build
branch
6 times, most recently
from
bd5e7ec to
7991450
Compare
castastrophe
force-pushed
the
fix-tokens-windows-build
branch
from
7991450 to
fda9dab
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When adding an experimental windows-latest run, I found that the style-dictionary compilation was failing pretty terrifically. This PR aims to fix that by wrapping pathing in path.join so that it can be rendered in a windows-friendly format.
Update the .gitattributes to force windows to use lf instead of crlf so that the generated mods files don't show a diff after the build.
Switch the style-dictionary build to use the vanilla command instead of the nx executor.
How and where has this been tested?
Please tag yourself on the tests you've marked complete to confirm the tests have been run by someone other than the author.
Validation steps
This can be validated via CI which will try to run the tokens build in windows. If the task fails, this PR did not work.
To-do list